Is this bad pratice

This is just an off question as i am not sure. Here is a random function i wrote.


Is it bad returning a function, while being inside a Loop or should i exit the loop first before returning?


Though sense functions return 0 by default, it could be this.